Fix type checks #75
Merged
Fix type checks #75
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The esiclient code contained a number of questionable type comparisons,
like this:
if type(var) == "str":
...
But this is problematic, and can fail if what you've received is actually a
subclass of the target type. In general, we should always use
`isinstance()` for checking the type of a variable.
See also the documentation on flake8 rule E721 [1].
[1]: https://www.flake8rules.com/rules/E721.html
tzumainn
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esiclient code contained a number of questionable type comparisons,
like this:
But this is problematic, and can fail if what you've received is actually a
subclass of the target type. In general, we should always use
isinstance()for checking the type of a variable.See also the documentation on flake8 rule E721 1.