WiFiNetwork: Extract WiFi dialog logic to separate fragment #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theimpulson
force-pushed
the
singleActivitySplit
branch
from
09e99f3
to
fd557a6
Compare
Signed-off-by: Aayush Gupta <[email protected]>
theimpulson
force-pushed
the
singleActivitySplit
branch
from
fd557a6
to
06d9cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the logic for displaying the WiFi dialog into a separate fragment to make it easier to migrate to a single activity architecture which I am working on right now. The user should observe no changes in behavior of the functionality with this PR.
Test
Open an event and ensure wifi dialog behaves the same