Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers and license #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ygshah
Copy link

@ygshah ygshah commented Feb 29, 2024

Made changes to the license file and headers in the python file, so the license is not copied over to each file.

InitGui.py~ Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backup file and shouldn't be included here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and other issues! Fixed this in the most recent commit and will submit another merge request.

Comment on lines 1 to 29
# ***************************************************************************
# * *
# * PackedColumnGen Copyright (c) 2012 - 2023, by the software owners: *
# * Oak Ridge Institute for Science and Education (ORISE), TRIAD *
# * National Security, LLC., Lawrence Livermore National Security, LLC., *
# * The Regents of the University of California, through Lawrence *
# * Berkeley National Laboratory, Battelle Memorial Institute, Pacific *
# * Northwest Division through Pacific Northwest National Laboratory, *
# * Carnegie Mellon University, West Virginia University, Boston *
# * University, the Trustees of Princeton University, The University of *
# * Texas at Austin, URS Energy & Construction, Inc., et al. *
# * All rights reserved. *
# * *
# * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS *
# * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT *
# * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS *
# * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE *
# * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT *
# * , INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES *
# * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR *
# * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) *
# * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN *
# * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR *
# * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, *
# * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. *
# * *
# * Authors: Yash Girish Shah, Grigorios Panagakos *
# * *
# ***************************************************************************
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is really needed in a __init__.py file, but should at least be shorted, as done in some of the other files, to just refer to the LICENSE.md file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this in the most recent commit.

@@ -0,0 +1,127 @@
from .preamble import *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ref to LICENSE.md?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short reference is added in the most recent commit. Thanks for catching this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this shouldn't be here either...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the executable file.

README.html Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate of the README.md file? If so, is it needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the html version. Git automatically displays the markdown files in a nice format, so the html file is not really needed here.

columnTree.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might be in the wrong place here at the top-level?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this file.

doc/User_Guide.html Outdated Show resolved Hide resolved
…y files. Cleaned up duplicates README.md was also present as an html.
@ygshah
Copy link
Author

ygshah commented Mar 13, 2024

Made changes into the most recent commit.

@ygshah ygshah closed this Mar 13, 2024
@ygshah ygshah reopened this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants