Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consideration on IHR priors? #161

Open
SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments
Open

More consideration on IHR priors? #161

SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments
Labels
experiment some sort of experiment to better understand a part of the model question Further information is requested

Comments

@SamuelBrand1
Copy link
Contributor

Given that this is a big model to compute (as in a lot of compartments), and we want to do Bayesian analysis, then its probably a good idea to make strong priors where possible.

I think the priors for infection-hospitalisation-ratio (IHR) are too vague and should probably reflect known age structure in IHR?

https://github.com/cdcent/cfa-scenarios-model/blob/dfbd4ded9fddf2dafcd793f73f751e6067ccd9f2/mechanistic_model/mechanistic_inferer.py#L130-L131

The prior range here looks like prior mean 4.8% IHR with 2.5-97.5% range: 0.005% - 22.7% with no age variation.

For me thats too vague and doesn't help the sampler (or indeed the reasoning); I think we can tighten those priors and add age structure.

NB: Pre-apologies if I'm not getting something here!

@SamuelBrand1 SamuelBrand1 added the question Further information is requested label Jun 4, 2024
@kokbent
Copy link
Collaborator

kokbent commented Jun 18, 2024

Yeah in the actual inference work we do, we usually bypassed the default mechanistic inferer to write a version of IHR with more stringent priors. Here's an example for our SMH work: https://github.com/cdcent/cfa-scenarios-model/blob/4d04c4a381d4d76a1f13e6b4dc45c4a4ec7d9ca7/exp/fifty_state_2202_2307_3strain/inferer_smh.py#L143

@SamuelBrand1
Copy link
Contributor Author

Yeah in the actual inference work we do, we usually bypassed the default mechanistic inferer to write a version of IHR with more stringent priors. Here's an example for our SMH work:

https://github.com/cdcent/cfa-scenarios-model/blob/4d04c4a381d4d76a1f13e6b4dc45c4a4ec7d9ca7/exp/fifty_state_2202_2307_3strain/inferer_smh.py#L143

Wouldn't it be easier to make something that takes in priors and return the likelihood function rather than almost C&P things, but hard coding prior changes?

@arik-shurygin arik-shurygin added the experiment some sort of experiment to better understand a part of the model label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment some sort of experiment to better understand a part of the model question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants