Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Standardize error msg #407

Closed
1 task done
prikiser opened this issue Nov 19, 2024 · 3 comments
Closed
1 task done

[Design] Standardize error msg #407

prikiser opened this issue Nov 19, 2024 · 3 comments
Assignees

Comments

@prikiser
Copy link
Collaborator

prikiser commented Nov 19, 2024

Standard error messaging to start off with

  • choose one style of error message where the user needs to take action

This will be our standard message error, let's deprioritize modal errors for now.
Figma design for download error which mimics template error

@prikiser
Copy link
Collaborator Author

@bora-skylight done with standard error message!

@bora-skylight
Copy link
Collaborator

Cool! So we can turn this into an eng ticket then @knguyenrise8.

@prikiser quick question, what is the error message supposed to look like if the page the error is on is not the review page, i.e. there is no table, should it just extend the full width of the page?

@prikiser
Copy link
Collaborator Author

@bora-skylight correct! There is an earlier error message that @knguyenrise8 did for the template mismatch. The design is the same it just extends to the full width like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants