Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Comparison Infrastructure #15

Open
AFg6K7h4fhy2 opened this issue Oct 9, 2024 · 5 comments
Open

Model Comparison Infrastructure #15

AFg6K7h4fhy2 opened this issue Oct 9, 2024 · 5 comments
Assignees
Labels
feature A new tool or utility being added. first-pass A first-pass at a specific task; typically evolves into something more substantial later. Low Priority A task that is of lower relative priority.
Milestone

Comments

@AFg6K7h4fhy2
Copy link
Collaborator

AFg6K7h4fhy2 commented Oct 9, 2024

Take at least two idata objects with the same fit and forecast period & compare.

Support comparison from

  • idata objects
  • FluSight submissions
@AFg6K7h4fhy2 AFg6K7h4fhy2 added the enhancement Enhancement to existing feature or aspect of the project. label Oct 9, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Oct 9, 2024
@damonbayer
Copy link
Contributor

Two points:

  1. We should think about comparing n forecasts when designing this
  2. Since scoring is an important part of model comparison, and scoring is done in scoringutils in R, we need to think carefully about how to use both ArviZ and scoringutils.

@AFg6K7h4fhy2
Copy link
Collaborator Author

Can you be more specific with this?

We should think about comparing $N$ forecasts when designing this.

Not sure what is meant here: (?) $N$ models (with one forecast dataframe per model) (?) $N$ jurisdictions per forecast dataframe (one dataframe per model).

For (2) I agree completely.

@damonbayer
Copy link
Contributor

Your original post mentions comparing 2 forecasts. I think whatever approach we take should be extensible to more than 2 forecasts.

@AFg6K7h4fhy2
Copy link
Collaborator Author

AFg6K7h4fhy2 commented Oct 9, 2024

Your original post mentions comparing 2 forecasts. I think whatever approach we take should be extensible to more than 2 forecasts.

Ah, I see. I should have been specific myself! at least two idata objects

@AFg6K7h4fhy2 AFg6K7h4fhy2 added feature A new tool or utility being added. first-pass A first-pass at a specific task; typically evolves into something more substantial later. and removed enhancement Enhancement to existing feature or aspect of the project. labels Oct 21, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added the Low Priority A task that is of lower relative priority. label Oct 28, 2024
@AFg6K7h4fhy2
Copy link
Collaborator Author

Adding this issue to the Backlog given that multiple, non-trivial issues (e.g. #32 , #18 , #9 , #34 ) remain to be completed before the functionality outlined in this issue will begin to be integrated.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the Backlog milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new tool or utility being added. first-pass A first-pass at a specific task; typically evolves into something more substantial later. Low Priority A task that is of lower relative priority.
Projects
None yet
Development

No branches or pull requests

2 participants