Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code from HL7Reader that is used places other than UP #16901

Open
2 tasks
adegolier opened this issue Dec 23, 2024 · 0 comments
Open
2 tasks

Remove old code from HL7Reader that is used places other than UP #16901

adegolier opened this issue Dec 23, 2024 · 0 comments
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality

Comments

@adegolier
Copy link
Collaborator

Problem statement

Deprecated code that is only used in the CLI should be removed from HL7Reader.kt

What you need to know

HL7Reader.getMessageProfile() and HL7Reader.profileDirectoryMap used only in ProcessFhirCommands.convertHl7ToFhir() should be removed and the use of it refactored to use current strategies. Along with removing this, the private val oidProfileMap can also be removed as it is only referenced in the getMessageProfile() function.

Acceptance criteria

  • HL7Reader.getMessageProfile(), HL7Reader.profileDirectoryMap, and HL7Reader.oidProfileMap are removed from HL7Reader
  • ProcessFhirCommands.convertHl7toFhir() is refactored to not need these things
@adegolier adegolier added platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Development

No branches or pull requests

1 participant