Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] [Feature] Write a new update_submission.py script #211

Open
1 task done
jessicarowell opened this issue Nov 7, 2024 · 0 comments
Open
1 task done

[Internal] [Feature] Write a new update_submission.py script #211

jessicarowell opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jessicarowell
Copy link
Collaborator

Instead of calling the only submission.py script, write a new one and have UPDATE_SUBMISSION module call that.

I did not originally do this because I didn't want to replicate code in two scripts. The original submission.py script needs to fetch report.xml files to get BioSample IDs, etc., so I wanted to re-use the same code in UPDATE_SUBMISSION. The problem there is that it copies all the inputs to a working directory, even the ones it doesn't use. That's really inefficient particularly when fastq files are in the inputs list.

Ideally, we want a separate update_submission.py script that will just take the INITIAL_SUBMISSION working directory as input. But we also want to minimize code replication because that's not a good practice (e.g., having to update code in two places).

Place an ❌ in a Box that Best Matches the Feature's Importance:

  • [] 1 - Most important (absolutely integral and will not use codebase at all without it)
  • [] 2-4 - Moderate (still using codebase for other functions but is serving as a blocker for future use-cases)
  • 5 - Least important (would like to see but there are no stringent expectations nor urgency for current/future use-cases) 

Any Additional Context or Information? Has There Been Any Progress Made So Far Towards this Request? Any Helpful Resources to Reference? Screenshots or Links?

@jessicarowell jessicarowell added the enhancement New feature or request label Nov 7, 2024
@jessicarowell jessicarowell added this to the v4.0.0 milestone Nov 7, 2024
@jessicarowell jessicarowell self-assigned this Nov 7, 2024
@jessicarowell jessicarowell modified the milestones: v4.0.0, v4.2.0 Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant