Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete initial SFTP config implementation #1680

Open
2 of 33 tasks
jcrichlake opened this issue Jan 3, 2025 · 0 comments
Open
2 of 33 tasks

Complete initial SFTP config implementation #1680

jcrichlake opened this issue Jan 3, 2025 · 0 comments

Comments

@jcrichlake
Copy link
Contributor

jcrichlake commented Jan 3, 2025

Story

As a future partner, so that I can also use the ingestion service and not only CA PHL, I need settings to be configurable instead of hard coded

As a partner, so that I can feel confident in the system, I need automated workflow testing to be able to include the ingestion service in addition to RS and TI

Acceptance Criteria

  • CA PHL isn't hard-coded anywhere other than the polling function - this means that where using config instead of using assumptions
  • Very basic config is available for at least one flexion org (enough to be able to put a file in a partner folder in the Azure container and have it be sent to ReportStream as the specified org)

Tasks

Engineering

  • In polling message handler, use queue message to:
    • build file paths for saving files (both zips and hl7s)
  • In import message handler:
    • parse file path to get partner ID
    • use partner ID to build key names for retrieving secrets to call RS
    • add config to tests
  • Do add'l TF to set up Flexion? (Simulated lab and/or golden copy or automated test sender)
    • Need secrets to call RS set up in the same pattern as the ca-phl ones
  • In handler.go
    • In the future, we'll pass in info about what customer we're using (and thus what URL/key/password to use)
  • Update example files for testing to use the new folder structure

Definition of Done

  • Documentation tasks completed
    • Documentation and diagrams created or updated
      • ADRs (/adr folder)
      • Main README.md
      • Other READMEs in the repo
      • If applicable, update the ReportStream Setup section in README.md
    • Threat model updated
    • API documentation updated
  • Code quality tasks completed
    • Code refactored for clarity and no design/technical debt
    • Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies
  • Testing tasks completed
    • Load tests passed
    • Additional e2e tests created
    • Additional RS e2e assertions created in the rs-e2e project for any new transformations. Includes improvements to the assertion code required to make the new assertions
  • Build & Deploy tasks completed
    • Build process updated
    • API(s) are versioned
    • Feature toggles created and/or deleted. Document the feature toggle
    • Source code is merged to the main branch

Note: Please remove any DoD items that are not applicable

Research Questions

  • Optional: Any initial questions for research

Decisions

  • Optional: Any decisions we've made while working on this story

Notes

  • Optional: Any reference material or thoughts we may need for later reference
@jcrichlake jcrichlake changed the title Update SFTP service to include partner specific directories Update SFTP service Jan 3, 2025
@somesylvie somesylvie changed the title Update SFTP service Complete initial SFTP config implementation Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant