Switching form for homepage without reloading page #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mething has messed up the layout in "create id" now.
…s the whole layout of the form.
5 tasks
|
Sure, if you like. Their problem with the old form was that the page reloading resets the user/screen reader place on the page (on the ark/doi radio buttons). This addresses it and is a fairly standard alternative to reloading the whole page so that the place on the page isn't reset by a page reload. But I'm sure we can run it by John Kratz or someone on the team and they'd be happy to look at it. |
|
We're not currently using this, though may be useful in the future. If we come back to this branch it will be here. |
|
Ooopsie. I think I accidentally closed the wrong ticket here and it wasn't merged. So re-opening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #541 .
This makes it so that switching to ARK or DOI changes the form below without reloading the page.
It also includes some of the previous fixes for VPAT stuff. If you accept that previous PR first then the diff will only show the things actually changed for this PR.
This now moves the form to a partial. It adds some actions controller actions for handling AJAX. It adds javascript for triggering the AJAX calls and then re-renders the new content into the appropriate div for the new form.
I also had to add some hidden fields and leave the radio buttons for the ARk/DOI outside the main form since it will get erased when the form is re-rendered so that it needs to stay outside the main form.
I took a while to figure out why the normal one didn't work and apparently the layout for it doesn't work with fieldset but needs to stay as a div instead.
We can talk through this in our dev sync or other things if you like since it may not be obvious how it works if you're not familiar with AJAX and some of the Javascript.