Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

727 test cleanup async queues 2 #791

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Nov 14, 2024

@sfisher Hi Scott,
This is to replace the proc-cleanup-async-queues.py script with proc-cleanup-async-queues_v2.py. A copy of the original script is saved as proc-cleanup-async-queues_v1.py. The _v1 and _v2 can be removed eventually after the refactored job runs stably in the production environment.

Please review. Thank you.

Jing

@jsjiang jsjiang requested a review from sfisher November 14, 2024 18:50
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @jsjiang . I like the arguments and it seems like you're handling all the cases for dates. :-)

@@ -45,6 +48,29 @@ class Command(ezidapp.management.commands.proc_base.AsyncProcessingCommand):
def __init__(self):
super().__init__()

def add_arguments(self, parser):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have arguments to customize how it works! :-)

@jsjiang jsjiang merged commit bc24eb0 into develop Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants