Revised Documentation for Accuracy #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…README & added hyperlink
mwodahl
requested changes
May 15, 2024
README.md
Outdated
|
|
||
| ** IN PROGRESS! Further instructions pending ODE compatibility. ** | ||
| ``` | ||
| docker compose -f docker-compose-confluent-cloud.yml up --build |
There was a problem hiding this comment.
Should this be updated to the command for running the docker-compose.yml file instead of the confluent cloud file when running kafka locally?
There was a problem hiding this comment.
Yes, good catch! This has been fixed
sample.env
Outdated
| @@ -1,13 +1,14 @@ | |||
| DOCKER_HOST_IP= | |||
| #SDW_GROUP_ID=usdot.jpo.sdw | |||
There was a problem hiding this comment.
Should the SDW_GROUP_ID be removed from here? It looks like we're not passing it in as an environment variable in any of the docker compose files
There was a problem hiding this comment.
You're right it doesn't seem to be getting used. This has been removed from the sample.env and README.md files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation for the project has been reviewed and revised for accuracy. In some cases, improvements were made to formatting/organization to improve clarity.
Changes