Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing capabilities on continuous energy mode #150

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Conversation

ilhamv
Copy link
Collaborator

@ilhamv ilhamv commented Jan 24, 2024

No description provided.

@jpmorgan98
Copy link
Collaborator

Do we have any verification/regression tests for continuous energy?

@ilhamv
Copy link
Collaborator Author

ilhamv commented Jan 25, 2024

Good point. But no, not yet. How should we deal with the data library in the GitHub workflow?

Copy link
Collaborator

@jpmorgan98 jpmorgan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good and classify as bug fixes. Eventually we will need documentation and testing but we have to wait on those while we get info from the higher ups.

@jpmorgan98
Copy link
Collaborator

Pull in updates then merge the request!

@jpmorgan98
Copy link
Collaborator

Just to put this here--we are getting guidance from PSAAP on how best to do continuous energy transport with export control considerations

@ilhamv ilhamv merged commit 4b63eeb into CEMeNT-PSAAP:main Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants