Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization #186

Closed
wants to merge 15 commits into from
Closed

Optimization #186

wants to merge 15 commits into from

Conversation

ilhamv
Copy link
Collaborator

@ilhamv ilhamv commented Apr 26, 2024

The optimization includes:

  • Tally now is a 3x1D numpy array (3 is for "score", "sum", and "sum_sq")
  • Refactor tally out of the mcdc global variable.
  • The tally is now put into a tuple named data, which can be accessed by the constant integer TALLY.
  • Now, particles are not stopped at mesh crossing (only at surface crossing or collision)

Other key changes:

  • Different tally scores are temporarily removed. The default flux score is currently used.
  • Regression tests need to be reset. Verification test is currently running.
  • The tally modification affects UQ-tally functions (@clemekay, please check...)

@ilhamv ilhamv requested review from clemekay and shac170 April 28, 2024 13:41
@ilhamv ilhamv marked this pull request as draft July 23, 2024 02:51
@ilhamv ilhamv mentioned this pull request Aug 14, 2024
Open
@ilhamv ilhamv mentioned this pull request Aug 26, 2024
Merged
2 tasks
@ilhamv ilhamv added the duplicate This issue or pull request already exists label Aug 26, 2024
@ilhamv
Copy link
Collaborator Author

ilhamv commented Aug 26, 2024 •
edited
Loading

This PR is broken into multiple PRs: #238 and #227.

@ilhamv
Copy link
Collaborator Author

ilhamv commented Aug 27, 2024

#238 has been merged, and #227 is about to be merged soon. This PR can be closed now.

@ilhamv ilhamv closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemekay clemekay Awaiting requested review from clemekay

@shac170 shac170 Awaiting requested review from shac170

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilhamv