Bug fix: particles sourced on cell boundaries #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the updated CSG functions a
particle is lost
error occurred if a particle was sourced exactly on a cell boundary. In standard Monte Carlo, this bug may never surface but samples in iQMC hit these boundaries quite often.In short, replacing
=
with<=
inregion_check()
returns the same cell ID as was calculated before the updates.