Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved tkinter to try/except in mcdc/visualizer #220

Closed
wants to merge 2 commits into from

Conversation

clemekay
Copy link
Collaborator

@clemekay clemekay commented Aug 6, 2024

@jpmorgan98 This isn't quite what you said you wanted to do in #214, but it maybe accomplishes the goals of that? Moving the tkinter module to the existing try/except module in mcdc/vis and adding a sys.exit() to the ImportError exception handling makes it so that any vis-dependency-related errors only print when trying to call mcdc.visualizer().

Making this a draft since I'm on a Mac that can't use the dependencies, I can only test the exception handling haha. If someone else could test that the visualizer itself still works, perhaps this small change is a good option?

@clemekay clemekay marked this pull request as draft August 6, 2024 22:40
@jpmorgan98
Copy link
Collaborator

I was planing on moving that whole visualizer to a sub-folder such that a user would have to import mcdc.visualizer. Kinda like scipy's integration library. That all these errors will show if a user specifically imports them

@clemekay clemekay closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants