-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/northroj/time cell tallies #282
Feature/northroj/time cell tallies #282
Conversation
I also updated the coincidence tolerance in this PR. I have not yet run into a geometry which causes this tolerance to fail, but I will keep looking. |
1 similar comment
I also updated the coincidence tolerance in this PR. I have not yet run into a geometry which causes this tolerance to fail, but I will keep looking. |
Thanks, Jordan! There are possible cases in which one would need a cell tally and domain decomposition at the same time. However, the cell tallies are less likely to be the kind of tally that needs decomposition. So, for now, this should be OK in most cases. I plan to review the PR soon tomorrow. |
It was weird that the MPI-Numba test passed, but the MPI-Python didn't. Re-running the latter now. |
@northroj - can you add a regression test for the time-meshed cell tally feature? |
@northroj - I really like your clear and complete input parameter descriptions in |
I am not sure what this means. The docstring in def cell_tally() was copied from the other tally docstrings, and I don't know what other tally parameter descriptions to update. |
…roj/MCDC into feature/northroj/time_cell_tallies
I just realized I cant use continuous energy for the regression test, I will get a mg one in. |
For @ilhamv: For a test of the cell tallies, I just added a cell tally to the inf_shem361 problem along with census to test the time and energy binning along with time census. I had to comment out the mesh tally because it produced a NAN for the stdev in the final energy group bin when census was enabled (it does not show up when census is commented out). I will add this to an issue. |
Oops. Looks like I messed up the commit history... Let me try fixing it. |
6dfa7c5
to
e1fa196
Compare
This PR adds time and energy binning to cell tallies Ethan added recently.
The structure was primarily copied from the mesh tallies. Domain decomposition support is currently not included. It is possible/probable that cell tallies crossing domain decomposition borders will cause errors, but it is unlikely that cell tallies would be used in the types of large problems where domain decomposition is used.
This has been tested on an approximate pulsed sphere problem currently being added to the challenge problem suite in conjunction with time census.