Skip to content

Commit

Permalink
self-review
Browse files Browse the repository at this point in the history
  • Loading branch information
kazet committed Oct 18, 2023
1 parent d64d156 commit 74394a7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions artemis/blocklist.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class BlocklistItem:
# block_reporting_only, blocks only reporting,
# - matches all the non-null items: domain, ip_range, ...
# - if all match, report/scanning is skipped.
# The same is repeated for all BlocklistItems - if at least one filters a given report, the report is skipped.
# The same is repeated for all BlocklistItems - if at least one matches, report/scanning is skipped.
mode: BlocklistMode
domain: Optional[str] = None
ip_range: Optional[Union[ipaddress.IPv4Network, ipaddress.IPv6Network]] = None
Expand Down Expand Up @@ -62,7 +62,7 @@ def load_blocklist(file_path: Optional[str]) -> List[BlocklistItem]:
}

for item in data:
# Assert there are no additional or missing keys
# Assert there are no additional keys
unexpected_keys = set(item.keys()) - expected_keys
if unexpected_keys:
raise BlocklistError(f"Unexpected keys in entry: {','.join(unexpected_keys)}")
Expand Down

0 comments on commit 74394a7

Please sign in to comment.