Add job enqueueing for domain scans #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-cert
reviewed
Jan 18, 2024
|
We already have refresh logic in the email check feature
czw., 18 sty 2024, 18:44 użytkownik msm-cert ***@***.***>
napisał:
… ***@***.**** commented on this pull request.
Some CI checks are failing.
Also consider auto reload of the page?
------------------------------
In app/templates/check_running.html
<#35 (comment)>:
> @@ -0,0 +1,15 @@
+{% extends "custom_layout.html" %}
+
+{% block body %}
+ <div class="container">
+ <div class="card">
+ <div class="card-body">
+ <h5 class="card-title">{% trans %}Domain analysis is running{% endtrans %}</h5>
+ <div class="card-text">
+ <img class="spinner waiting" src="/static/images/spinner.svg" />
+ <h5 class="waiting">{% trans %}Waiting for the domain analysis to finfish{% endtrans %}</h5>
maybe add an autmatic page refresh every 5s here (with javascript or http
header or http-equiv)?
—
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJNBK4MSSKURJRGSROD42LYPFNPVAVCNFSM6AAAAABCAU42G6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZQGI2TANZRGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
mimi89999
force-pushed
the
jobs
branch
4 times, most recently
from
f1b6895
to
f328f35
Compare
kazet
reviewed
Jan 22, 2024
kazet
reviewed
Jan 22, 2024
kazet
reviewed
Jan 23, 2024
kazet
reviewed
Jan 23, 2024
kazet
reviewed
Jan 23, 2024
kazet
reviewed
Jan 23, 2024
kazet
reviewed
Jan 23, 2024
mimi89999
force-pushed
the
jobs
branch
3 times, most recently
from
4b8b05b
to
950abbb
Compare
kazet
reviewed
Jan 24, 2024
| {% block body %} | ||
| <div class="container"> | ||
| <div class="p-4"> | ||
| <h1>{% trans %}Configuration analysis is running{% endtrans %}</h1> |
There was a problem hiding this comment.
looking a lot nicer than the original!
kazet
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.