Don't gather download token for authenticated file download #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
force-pushed
the
fix/dont-use-token-for-download
branch
from
5af6299
to
1cce767
Compare
nazywam
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download token is needed only for convenient downloads from UI, where we can't easily pass Authorization header to the request. Using direct call to API, we need to make only one request to download file contents.
MWDB Core code that handles authenticated download:
https://github.com/CERT-Polska/mwdb-core/blob/3be33c65e25419da89212afa174415d58d908fc8/mwdb/resources/file.py#L441-L445