Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/limited cache #41

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Feature/limited cache #41

wants to merge 8 commits into from

Conversation

plally
Copy link
Member

@plally plally commented Sep 5, 2023

This resolves #39

Some benchmarking and testing could be done before merging. A cache here might not even be necessary here or may be more beneficial on the GetOptionsForURL function

@Grocel
Copy link

Grocel commented Sep 5, 2023

Maybe you would like to create a library for the newly and other created data structures.

@plally
Copy link
Member Author

plally commented Sep 5, 2023

Maybe you would like to create a library for the newly and other created data structures.

What do you mean, like a new repo/project?

@Grocel
Copy link

Grocel commented Sep 6, 2023

Maybe you would like to create a library for the newly and other created data structures.

What do you mean, like a new repo/project?

Yes, because I think that's an issue that happens more often than you would think. It might be needed to solve it often.

@plally
Copy link
Member Author

plally commented Sep 6, 2023

Maybe. The only reason I don't do that is gmod doesnt really have a good way to manage dependencies for non workshop addons. So you have to make people go and download a bunch of dependencies for your addon and adding dependencies would break the addon for people who auto update from git.

@Grocel
Copy link

Grocel commented Sep 6, 2023

Maybe. The only reason I don't do that is gmod doesnt really have a good way to manage dependencies for non workshop addons. So you have to make people go and download a bunch of dependencies for your addon and adding dependencies would break the addon for people who auto update from git.

Yes, indeed. GMod is pain when it comes to dependencies. There are some dependency managers out there, but they are all kinda weird and not that well maintained. Even using workshop for dependency management is meh and it is definitely not idiot proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFCHTTP.GetAddress() could memory leak by cache.
2 participants