Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMP::isotropic_remeshing - add variable sizing field #4891

Merged
merged 129 commits into from
Nov 19, 2023
Merged

PMP::isotropic_remeshing - add variable sizing field #4891

merged 129 commits into from
Nov 19, 2023

Conversation

janetournois
Copy link
Member

@janetournois janetournois commented Jul 30, 2020 •
edited by sloriot
Loading

Summary of Changes

This PR introduces the possibility to chose a variable sizing field for isotropic remeshing.

Release Management

  • Affected package(s): PMP
  • Feature/Small Feature (if any): Here -- pre-approval on 2023/10/24
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged
  • Depends on GSoC2022 - Interpolated Corrected Curvatures  #6760

TODO:

  • check branch size (for @sloriot)
  • handle the update of the interpolated curvature branch (for @sloriot)

@janetournois janetournois self-assigned this Jul 30, 2020
@maxGimeno

This comment was marked as outdated.

Sign in to view
@janetournois

This comment was marked as outdated.

Sign in to view
@maxGimeno maxGimeno added this to the 5.3-beta milestone Oct 20, 2020
@sloriot sloriot modified the milestones: 5.3-beta, 5.4-beta Mar 11, 2021
@anishsingh935

This comment has been minimized.

Sign in to view
@anishsingh935

This comment has been minimized.

Sign in to view
@anishsingh935

This comment has been minimized.

Sign in to view
@maxGimeno

This comment has been minimized.

Sign in to view
@anishsingh935

This comment has been minimized.

Sign in to view
@anishsingh935

This comment has been minimized.

Sign in to view
@sloriot sloriot force-pushed the PMP-add_sizing_in_isotropic_remeshing-GF branch from ba3c993 to 7379d58 Compare April 11, 2021 05:45
@sloriot
Copy link
Member

sloriot commented Apr 11, 2021 •
edited
Loading

Uniform_sizing_field must be renamed or put in a namespace as it conflicts with the class in Tetra remeshing package.

@kabirkedia kabirkedia mentioned this pull request Apr 13, 2021
Closed
@kabirkedia

This comment was marked as outdated.

Sign in to view
@sloriot sloriot modified the milestones: 5.4-beta, 5.5-beta1 Sep 30, 2021
@janetournois janetournois force-pushed the PMP-add_sizing_in_isotropic_remeshing-GF branch from 9bce3d2 to f166f96 Compare January 18, 2022 10:20
@sloriot sloriot modified the milestones: 5.5-beta, 5.6-beta Apr 12, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 31, 2023
@janetournois
add possibility to provide a variable sizing field to PMP::isotropic_…
0ee9406 
…remeshing

# Conflicts:
#	Polygon_mesh_processing/examples/Polygon_mesh_processing/CMakeLists.txt
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h
@janetournois
use boost::optional<double> instead of a bool and a double
9de4131 
# Conflicts:
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h
@sloriot sloriot force-pushed the PMP-add_sizing_in_isotropic_remeshing-GF branch from 489a288 to 4c7bc4c Compare November 16, 2023 08:50
@github-actions github-actions bot removed the Tested label Nov 16, 2023
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot removed the TODO label Nov 16, 2023
@sloriot sloriot changed the base branch from master to 5.5.x-branch November 16, 2023 09:04
@sloriot sloriot changed the base branch from 5.5.x-branch to master November 16, 2023 09:04
@sloriot
remove todo
38482e8 
There will not be any crash as the value for new vertices
is always set. However with Polyhedron since we don't reuse
vertices, the map size might get large. Surface_mesh is fine
@sloriot
Copy link
Member

sloriot commented Nov 19, 2023

Successfully tested in CGAL-6.0-Ic-109

@sloriot sloriot merged commit 5c62ae4 into CGAL:master Nov 19, 2023
9 checks passed
@lrineau
Copy link
Member

lrineau commented Nov 24, 2023

Note that it seems the change has not been announced in CHANGES.md.

@janetournois janetournois mentioned this pull request Nov 27, 2023
Merged
@janetournois
Copy link
Member Author

Note that it seems the change has not been announced in CHANGES.md.

fixed by #7887

lrineau added a commit that referenced this pull request Nov 27, 2023
@lrineau
PMP - isotropic remeshing with sizing to CHANGES.md (#7887)
3b86663 
## Summary of Changes

Forgotten in PR #4891 

## Release Management

* Affected package(s): Installation
* License and copyright ownership: unchanged
@sloriot sloriot deleted the PMP-add_sizing_in_isotropic_remeshing-GF branch October 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

@afabri afabri afabri left review comments

@lrineau lrineau lrineau left review comments

@ipadjen ipadjen ipadjen left review comments

Assignees

@janetournois janetournois

Labels
Accepted small feature Enhancement gsoc gsoc-2023 Merged_in_6.0 Pkg::PMP Small feature Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
9 participants
@janetournois @maxGimeno @anishsingh935 @sloriot @kabirkedia @ipadjen @lrineau @afabri @MaelRL