Improve the manuals for the 3D Polyhedral Surface and Triangulated Surface Mesh Segmentation pkgs #7540
Conversation
sloriot
added
Enhancement
Not yet approved
|
Successfully tested in CGAL-6.0-Ic-15 |
sloriot
added
Tested
and removed
Under Testing
Batch_1
@sloriot You marked the pull-request with https://github.com/CGAL/cgal/labels/not%20yet%20approved. Do you think it is ready to be merged, now? |
| - \f$\lambda \in [0,1]\f$ denotes a smoothness parameter. | ||
| </td> | ||
| </tr> | ||
| </table> | ||
|
|
||
| Note both terms of the energy function, \f$ e_1 \f$ and \f$ e_2 \f$, are always non-negative. | ||
| The first term of the energy function provides the contribution of the soft clustering probabilities. | ||
| The second term of the energy function is a geometric criterion that is larger when two adjacent facets sharing a sharp and concave edge are not in the same cluster. | ||
| The second term of the energy function is a geometric criterion that is larger when two adjacent facets sharing a straight dihedral angle are not in the same cluster. |
There was a problem hiding this comment.
@lrineau changes are OK and for "straight dihedral angle" I don't know what it means.
There was a problem hiding this comment.
Hi @sloriot,
I meant to write the complete opposite of what was written.
What if we write: "[...] sharing a flat edge, i.e. a straight dihedral angle, are not [...]"?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I guess we can use almost flat dihedral angle instead of straight.
|
This pull-request was previously marked with the label |
| - \f$\lambda \in [0,1]\f$ denotes a smoothness parameter. | ||
| </td> | ||
| </tr> | ||
| </table> | ||
|
|
||
| Note both terms of the energy function, \f$ e_1 \f$ and \f$ e_2 \f$, are always non-negative. | ||
| The first term of the energy function provides the contribution of the soft clustering probabilities. | ||
| The second term of the energy function is a geometric criterion that is larger when two adjacent facets sharing a sharp and concave edge are not in the same cluster. | ||
| The second term of the energy function is a geometric criterion that is larger the larger the dihedral angle between two adjacent facets not in the same cluster. |
There was a problem hiding this comment.
I've rephrased it a bit, how does this look?
There was a problem hiding this comment.
Except if I'm wrong you have a greater contribution the closer you are to 180 degrees. I guess that's what you meant but largest angle could be 360 degree.
There was a problem hiding this comment.
You're quite right. I've reworded it again and included the valid range for theta in the description of the expression symbols.
Surface_mesh_segmentation/doc/Surface_mesh_segmentation/Surface_Mesh_Segmentation.txt
Outdated
Show resolved
Hide resolved
…er manual Co-authored-by: Sebastien Loriot <[email protected]>
sloriot
added
Under Testing
Batch_1
|
Successfully tested in CGAL-6.0-Ic-20 |
lrineau
added
the
rm only: ready for master
lrineau
added
the
rm only: ready for release branch
Improve the manuals for the 3D Polyhedral Surface and Triangulated Surface Mesh Segmentation pkgs
lrineau
removed
rm only: ready for master
Hi @sloriot,
Unfortunately, I still don't think the changes in #7523 correctly describe the mesh segmentation algorithm.
I've checked the code, and it looks sound to me, it's doing what intuitively I'd expect it to. :)
Now the description matches that code and intuition.
I hope I'm not coming across as too annoying...
Cheers,
-Nuno