Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification: Workaround for VC++/std17/boost bug #7578

Merged

Conversation

afabri
Copy link
Member

@afabri afabri commented Jul 6, 2023

Summary of Changes

VC2022 with std17 and boost 1_82_0 have a N in the Classification testsuite.
We reported an issue at boost/core
The workaround is to make the copy constructor public.

See also the discussion on the issue in boost/core

Release Management

  • Affected package(s): Classification

@afabri afabri added Ready to be tested Pkg::Classification upstream bug Bugs in third party software used by CGAL labels Jul 6, 2023
@afabri afabri added this to the 6.0-beta milestone Jul 6, 2023
@sloriot sloriot added Under Testing Batch_1 First Batch of PRs under testing and removed Under Testing Batch_1 First Batch of PRs under testing labels Jul 6, 2023
@sloriot
Copy link
Member

sloriot commented Jul 13, 2023

@lrineau lrineau self-assigned this Jul 13, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 13, 2023
@lrineau lrineau merged commit 07b1e26 into CGAL:master Jul 17, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 26, 2023
@lrineau lrineau deleted the Classification-Visual_cpp17_boost_1_80_bug-GF branch July 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged_in_6.0 Pkg::Classification Tested upstream bug Bugs in third party software used by CGAL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants