Triangulation_3: the testsuite of the simplex traverser needs C++17 #7611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_simplex_iterator_3.cpp` and `test_segment_simplex_traverser_3.cpp` require C++17.
lrineau
added
Under Testing
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Jul 26, 2023
…estsuite_cpp17-lrineau Triangulation_3: the testsuite of the simplex traverser needs C++17
lrineau
deleted the
Triangulation_3-fix_traverser_testsuite_cpp17-lrineau
branch
lrineau
added
Merged_in_5.6
and removed
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The files
test_simplex_iterator_3.cppandtest_segment_simplex_traverser_3.cpprequire C++17. This pull-request fixes the CMake logic so that they are only compiled if the compiler is able to use C++17.Fix Triangulation_3 test suite on a few compilers:
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.6-I-277/Triangulation_3/TestReport_Christo_MSVC2017-Debug-64bits.gz
Release Management
Not a blocker in my option.