Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream_support: Add read_VTK() #7826

Merged
merged 14 commits into from
Dec 18, 2023
Merged

Stream_support: Add read_VTK() #7826

merged 14 commits into from
Dec 18, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Oct 25, 2023 •
edited
Loading

Summary of Changes

Add read_VTK() so that we can also read non-xml *.vtk files.

  • Document it correctly

Release Management

  • Affected package(s): Stream_support

  • Feature/Small Feature (if any):

  • Link to compiled documentation: overview and function

  • License and copyright ownership:

@afabri afabri requested a review from MaelRL October 25, 2023 09:12
@afabri afabri added this to the 6.0-beta milestone Oct 25, 2023
@afabri afabri mentioned this pull request Oct 25, 2023
Closed
@lrineau
Copy link
Member

lrineau commented Oct 30, 2023

@afabri You mention a TODO in the first message

Document it correctly

What is left to be done?

And should not be another variant in <CGAL/boost/graph/IO/VTK.h> to read a face graph directly?

@lrineau lrineau added the TODO label Oct 30, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_1 First Batch of PRs under testing labels Nov 28, 2023
@sloriot
Copy link
Member

sloriot commented Dec 7, 2023

Successfully tested in CGAL-6.0-Ic-122

@lrineau
Copy link
Member

lrineau commented Dec 7, 2023

@afabri This PR is tested but still not finished, according to the TODO list. I do not know what is left to be done. Note that I asked the same question in a previous message (#7826 (comment)).

@github-actions github-actions bot removed the Tested label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@afabri
Copy link
Member Author

afabri commented Dec 7, 2023

/build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 7, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 7, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 7, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

There was an error while building the doc:

/home/runner/work/cgal/cgal/Stream_support/doc/Stream_support/File_formats/Supported_file_formats.txt:461: warning: unable to resolve link to 'PkgBGLIoFuncsVTK' for \link command
/home/runner/work/cgal/cgal/Stream_support/doc/Stream_support/File_formats/Supported_file_formats.txt:472: warning: unable to resolve link to 'PkgBGLIoFuncsVTK' for \link command

https://github.com/CGAL/cgal/actions/runs/7128486551

@afabri
Copy link
Member Author

afabri commented Dec 7, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 8, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 13, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Dec 13, 2023

/force-build:v0

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7826/v0/Manual/index.html

@sloriot
Copy link
Member

sloriot commented Dec 18, 2023

Successfully tested in CGAL-6.0-Ic-129

@sloriot sloriot self-assigned this Dec 18, 2023
@sloriot sloriot merged commit 1787da4 into CGAL:master Dec 18, 2023
9 checks passed
@sloriot sloriot deleted the Stream_support-read_VTK-GF branch December 18, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albert-github albert-github albert-github left review comments

@MaelRL MaelRL Awaiting requested review from MaelRL

Assignees

@sloriot sloriot

Labels
Merged_in_6.0 Pkg::Stream_support Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@afabri @lrineau @sloriot @albert-github