Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC2023 - ACVD for Simplification & Remeshing #7837

Open
wants to merge 65 commits into
base: master
Choose a base branch
from

Conversation

hoskillua
Copy link
Member

@hoskillua hoskillua commented Oct 31, 2023

Release Management

TODO

  • remove commit introducing interpolated_corrected_curvatures.h after the merge of the gsoc2022 branch
  • remove qem_metrics.h and types.h from history (for @sloriot)
  • check branch size (for @sloriot)
  • handle interpolated curvature update (for @sloriot)
  • debug the QEM minimization implementation (for @hoskillua)
  • test the other versions as possibly some cases produce bad results (for @hoskillua)
  • code cleanup (especially the logic for computing energy difference on edge and moving an element for @hoskillua )
  • recompute the energy after each convergence (for @hoskillua)

@sloriot sloriot force-pushed the gsoc2023 branch 2 times, most recently from 16c72f2 to 37b16ab Compare March 26, 2024 15:24
@afabri
Copy link
Member

afabri commented Jun 7, 2024

What are the next steps for this package?
Is it complete and is it bug free, and basically needs just a submission as (small?) feature?
I noticed that there is no testsuite.
And also Eigen is hardwired and not a model of a Solver concept. Does what is done here correspond to an existing Solver concept?

@MaelRL MaelRL added this to the 6.1-beta milestone Jun 7, 2024
@hoskillua
Copy link
Member Author

What are the next steps for this package? Is it complete and is it bug free, and basically needs just a submission as (small?) feature? I noticed that there is no testsuite. And also Eigen is hardwired and not a model of a Solver concept. Does what is done here correspond to an existing Solver concept?

Unfortunately, it is not. I didn't get the chance to get into it in the past month but I am planning to work more on it later this month. Sorry for being late on that.

@sloriot sloriot changed the base branch from master to 5.5.x-branch October 18, 2024 12:59
@sloriot sloriot changed the base branch from 5.5.x-branch to master October 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants