Treeview missing due to missing setting in header_package.html
#7956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR CGAL#7946 was withdraw because the `$cookie` was not necessary anymore in the `header...` files as it was part of the of the `$treeview`. In `header_package.html` the `$treeview` has been disables and as such the `cookie.js` is not added/ Adding the `cookie.js` explicitly. The effect was that there was a divider between the treeniew and the textual documentation but it was on the far left (and thus invisible), ith could be moved but after a refresh it was "gone" again.
sloriot
added
Batch_2
|
I don't see any difference between CGAL-6.0-Ic-147 and CGAL-6.0-I-145 |
|
Please compare https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.0-Ic-147/master/Algebraic_foundations/group__PkgAlgebraicFoundationsRef.html and https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.0-I-145/master/Algebraic_foundations/group__PkgAlgebraicFoundationsRef.html when going through:
147 145 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #7946 was withdraw because the
$cookiewas not necessary anymore in theheader...files as it was part of the of the$treeview. Inheader_package.htmlthe$treeviewhas been disables and as such thecookie.jsis not added/ Adding thecookie.jsexplicitly.The effect was that there was a divider between the treeview and the textual documentation but it was on the far left (and thus invisible), it could be moved but after a refresh it was "gone" again.