Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Installation/README #7959

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Update Installation/README #7959

merged 2 commits into from
Jan 11, 2024

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jan 3, 2024

Summary of Changes

There were inconsistencies with what was actually being shipped.

Also, switch it to markdown and clean it up here and there.

Release Management

  • Affected package(s): Installation
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): n/a
  • License and copyright ownership: n/a

@MaelRL MaelRL added the Doc label Jan 3, 2024
@MaelRL MaelRL added this to the 6.0-beta milestone Jan 3, 2024
@MaelRL MaelRL requested a review from lrineau January 3, 2024 14:14
albert-github
albert-github reviewed Jan 3, 2024
View reviewed changes
Installation/README.md Outdated Show resolved Hide resolved
Installation/README.md Outdated Show resolved Hide resolved
Installation/README.md Outdated Show resolved Hide resolved
Installation/README.md Outdated Show resolved Hide resolved
Installation/README.md Outdated Show resolved Hide resolved
@sloriot sloriot added Batch_2 Second Batch of PRs under testing Under Testing and removed Batch_2 Second Batch of PRs under testing labels Jan 3, 2024
@sloriot
Copy link
Member

sloriot commented Jan 11, 2024

Successfully tested in CGAL-6.0-Ic-147

@lrineau lrineau self-assigned this Jan 11, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
@lrineau lrineau merged commit 2168d6e into CGAL:master Jan 11, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
@lrineau lrineau deleted the Installation-Update_README-GF branch January 11, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albert-github albert-github albert-github approved these changes

@lrineau lrineau lrineau approved these changes

Assignees

@lrineau lrineau

Labels
Doc Merged_in_6.0 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@MaelRL @sloriot @albert-github @lrineau