Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execute_process that is recommanded over exec_command since 3.0 #7963

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Jan 4, 2024

I tested locallly uninstall and it works (I noticed however that empty directories created by CGAL are left, but that's also the case with the version before the update).

@sloriot sloriot added CMake scripts Warnings For an issue about warnings, or a pull-request that fixes warnings Cleaning labels Jan 4, 2024
@lrineau lrineau added this to the 5.5.4 milestone Jan 4, 2024
@sloriot
Copy link
Member Author

sloriot commented Jan 11, 2024

Successfully tested in CGAL-6.0-Ic-147

@lrineau lrineau self-assigned this Jan 11, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
lrineau added a commit that referenced this pull request Jan 11, 2024
Use execute_process that is recommanded over exec_command since 3.0
lrineau added a commit that referenced this pull request Jan 11, 2024
Use execute_process that is recommanded over exec_command since 3.0
@lrineau lrineau merged commit bb986ee into CGAL:5.5.x-branch Jan 11, 2024
8 checks passed
@lrineau lrineau deleted the CGAL-cmake_remove_exec_command branch January 11, 2024 12:00
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
@lrineau lrineau mentioned this pull request Jan 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants