Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment_delaunay_graph_2: Fix Issue 7972 #7975

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Segment_delaunay_graph_2: Fix Issue 7972 #7975

merged 2 commits into from
Jan 24, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Jan 11, 2024

Summary of Changes

Using the exact construction kernel reveals a bug. A function returns a reference to a local variable.

Release Management

@afabri afabri added this to the 5.6.1 milestone Jan 11, 2024
@afabri afabri requested a review from MaelRL January 11, 2024 08:48
@MaelRL MaelRL changed the base branch from 5.6.x-branch to 5.5.x-branch January 11, 2024 09:51
@MaelRL MaelRL modified the milestones: 5.6.1, 5.5.4 Jan 11, 2024
@MaelRL MaelRL linked an issue Jan 11, 2024 that may be closed by this pull request
Segmentation fault on insert_segments of Segment Delaunay Graph using exact constructions kernel #7972
Closed
@sloriot
Copy link
Member

sloriot commented Jan 24, 2024

Successfully tested in CGAL-6.0-Ic-156

@lrineau lrineau self-assigned this Jan 24, 2024
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Jan 24, 2024
@lrineau lrineau modified the milestones: 5.5.4, 5.6.1 Jan 24, 2024
lrineau added a commit that referenced this pull request Jan 24, 2024
@lrineau
Merge pull request #7975 from afabri/SDG2-fix7972-GF
02263fa 
Segment_delaunay_graph_2:  Fix Issue 7972
@lrineau lrineau merged commit 074a058 into CGAL:5.5.x-branch Jan 24, 2024
8 checks passed
lrineau added a commit that referenced this pull request Jan 24, 2024
@lrineau
Merge pull request #7975 from afabri/SDG2-fix7972-GF
92c0c69 
Segment_delaunay_graph_2:  Fix Issue 7972
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Jan 24, 2024
@lrineau lrineau deleted the SDG2-fix7972-GF branch January 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL Awaiting requested review from MaelRL

Assignees

@lrineau lrineau

Labels
Merged_in_5.5.4 Merged_in_5.5.5 Merged_in_5.6.1 Merged_in_6.0 Pkg::Segment_Delaunay_graph_2 Tested
Projects
None yet
Milestone
5.5.4
Development

Successfully merging this pull request may close these issues.

Segmentation fault on insert_segments of Segment Delaunay Graph using exact constructions kernel
4 participants
@afabri @sloriot @MaelRL @lrineau