Point_set_3: property uchar refers to the range 0..255 not the char type #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully tested in CGAL-6.0-Ic-169 |
lrineau
added
the
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Feb 13, 2024
Point_set_3: property uchar refers to the range 0..255 not the char type
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the ply file format one specifies in the header the type of properties. For a color one typically writes
property uchar red, and then later writes a number between 0 and 255. We wrote a single char which is a mistake and was reported in issue #7996. Note that even the CGAL ply reader cannot read it. And there is a comment in the reader which explains that it reads an integer string and not a single char.Release Management