Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite: enhanced summary page with JSON generation and search functionality #8127

Merged

Conversation

SaillantNicolas
Copy link
Member

@SaillantNicolas SaillantNicolas commented Apr 8, 2024

Summary of Changes

The summary page is now generated using a JSON file.
A search bar has been added to the summary page.


The version of this Pull Request can be reviewed at this link.

@lrineau
Copy link
Member

lrineau commented Apr 25, 2024

That seems a very nice improvement. @sloriot Does it fit the needs?

@lrineau
Copy link
Member

lrineau commented May 21, 2024

That seems a very nice improvement. @sloriot Does it fit the needs?

@sloriot

The version of this Pull Request can be reviewed at this link.

Can you please check if that corresponds to the needs?

@sloriot
Copy link
Member

sloriot commented May 21, 2024

Sorry, I remember discussing it on element. Looks good to me. The filtration could be improved. Indeed packages are filtered out globally but not depending on the selected case to be reported (n,w,o,...). But it is not a blocking point and could be merged as is as it is really helpful.

@lrineau lrineau assigned lrineau and unassigned sloriot May 21, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 21, 2024
@lrineau
Copy link
Member

lrineau commented May 21, 2024

Sorry, I remember discussing it on element. Looks good to me. The filtration could be improved. Indeed packages are filtered out globally but not depending on the selected case to be reported (n,w,o,...). But it is not a blocking point and could be merged as is as it is really helpful.

I'll merge it, and later improvements will be another pull-request...

@lrineau lrineau merged commit 64c6fa7 into CGAL:master May 21, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 21, 2024
@SaillantNicolas SaillantNicolas linked an issue Jun 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment