Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface_mesh: Add exact_num_faces(const SM&) #8215

Merged
merged 2 commits into from
May 26, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented May 22, 2024

Summary of Changes

Add a partial specialization for CGAL::internal::exact_num_faces(const Surface_mesh&) to have an O(1) time. This was pointed out as important for the Face_count_stop_predicate in Issue #8158

Release Management

@sloriot
Copy link
Member

sloriot commented May 22, 2024

why only one and not the four?

@MaelRL MaelRL added the TODO label May 22, 2024
@lrineau
Copy link
Member

lrineau commented May 23, 2024

TODO: that new function overload needs a test.

It is used in Surface_mesh_simplification. How do you want me to check that the specialization is taken? Add an #ifdef CGAL_TESTSUITE with a std::cout ?

@sloriot
Copy link
Member

sloriot commented May 26, 2024

Successfully tested in 6.0-Ic-251

@sloriot sloriot merged commit 94b9726 into CGAL:5.6.x-branch May 26, 2024
8 checks passed
@sloriot sloriot deleted the Surface_mesh-exact_num_faces-GF branch May 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants