edge-collapse: garland-heckbert: no non-zero precondition for cost matrices #8345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trices Before: The non-probabilistic garland-heckbert strategies (planar and triangular) trigger the precondition for cost matrices to be non-zero after initialization, when the mesh contains vertices surrounded by degenerate triangles. Now: the non-zero precondition check is applied for probabilistic strategies only (planar-probablistic and triangular-probabilistic). The non-probabilistic strategies behave well-defined for non-invertible cost matrices, including all-zero cost-matrices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: The non-probabilistic garland-heckbert strategies (planar and triangular) trigger the precondition for cost matrices to be non-zero after initialization, when the mesh contains vertices surrounded by degenerate triangles.
Now: the non-zero precondition check is applied for probabilistic strategies only (planar-probablistic and triangular-probabilistic). The non-probabilistic strategies behave well-defined for non-invertible cost matrices, including all-zero cost-matrices.
Please use the following template to help us managing pull requests.
Summary of Changes
Describe what your pull request changes to CGAL (this can be skipped if it solves an issue already in the tracker or if it is a Feature or Small Feature submitted to the CGAL Wiki).
Release Management