Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab - add polylines to selection of edges #8411

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Lab - add polylines to selection of edges #8411

wants to merge 12 commits into from

Conversation

janetournois
Copy link
Member

Summary of Changes

With this PR

  • load a surface triangle mesh
  • load a set of polylines (*.polylines.txt, or *.cgal, or *.txt)
  • create a selection item containing the polylines as selected edges (in PMP -> Select edges)

Release Management

  • Affected package(s): CGAL lab
  • License and copyright ownership: unchanged

@janetournois janetournois added this to the 6.1-beta milestone Aug 13, 2024
afabri
afabri reviewed Sep 17, 2024
View reviewed changes
...esh_processing/include/CGAL/Polygon_mesh_processing/internal/Corefinement/face_graph_utils.h
@@ -1680,7 +1680,7 @@ void
remove_patches(TriangleMesh& tm,
const boost::dynamic_bitset<>& patches_to_remove,
PatchContainer& patches,
const EdgeMarkMap& edge_mark_map)
EdgeMarkMap& edge_mark_map)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change leads to a failure in the CI

@janetournois janetournois force-pushed the Lab-polyline_features-jtournois branch from 0d1ecbe to 95be09a Compare October 1, 2024 12:51
@afabri
Copy link
Member

afabri commented Oct 15, 2024

Warnings in I-c-348, but I think it is to early for the testsuite as there are todos in the code and lots of debug std::cout, which is normal as this is only a draft PR @sloriot

@afabri
Copy link
Member

afabri commented Oct 18, 2024

I guess the warning in I-c-351 comes from this PR.

@janetournois can you check if the plugin does what you want to achieve.
I can then throw out debug code and output.

@janetournois janetournois marked this pull request as ready for review October 18, 2024 08:55
sloriot
sloriot reviewed Oct 18, 2024
View reviewed changes
Lab/demo/Lab/Plugins/PMP/Selection_plugin.cpp Outdated

auto locate_vertex = [&](const Point_3& p)->vertex_descriptor
{
const double tol = 1e-5; //todo : make tolerance depend on bbox size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unused variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

@afabri afabri afabri left review comments

Assignees
No one assigned
Labels
CGAL 3D demo Under Testing
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@janetournois @afabri @sloriot @soesau