-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poly-geodesic arc Handling #8477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e boundary of the parameter space.
…hat accept points, which could lie on the boundary of the parameter space.
afabri
reviewed
Oct 15, 2024
Arrangement_on_surface_2/include/CGAL/Arr_polycurve_basic_traits_2.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Oct 15, 2024
Arrangement_on_surface_2/include/CGAL/Arr_polycurve_basic_traits_2.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Fabri <[email protected]>
Successfully tested in CGAL-6.0.1-Ic-351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed handling poly-curves. Poly-curves are piecewise curves that are not necessarily linear, that is, chains of connected curves of a specific type. Most of fixes in this PR apply to code that handles poly-curves, where the curves are geodesic arcs on the sphere. Observe that polylines (piecewise linear curves) are a specific type of poly-curves.
Summary of Changes
Most of the changes are made in the file Arr_polycurve_basic_traits_2.h of the "2D Arrangements" package.
The class template Arr_polyline_traits_2 derives from Arr_polycurve_traits_2, which in turn derives from Arr_polycurve_basic_traits_2. Each class in this hierarchy adds some functionality.
They all handle poly-curves. The first handles polylines; the other two handle poly-curves. The template parameter SubcurveTraits is referred to as the subcurve traits.
Release Management