Fixed the code that computes intersection #8525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Efi. The issue #8468 was reported against CGAL-5.4. This pull-request is for |
|
Yes, I would, but mostly because of the performance boost for polylines
(and not the fix for polycurves that are not polylines).
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 9 Oct 2024 at 11:48, Laurent Rineau ***@***.***> wrote:
Hi Efi. The issue #8468 <#8468> was
reported against CGAL-5.4. This pull-request is for master. Should not it
be backported to release branches? CGAL-5.4.x is no longer supported, but
maybe 5.5.x-branch?
—
Reply to this email directly, view it on GitHub
<#8525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOELDISB7PCB2M7T6HLZ2TUW7AVCNFSM6AAAAABPQZBX5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRG4ZDCNZWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It is rather non-minimalistic with all these |
|
Indeed. It is not minimalistic in any sense.
I tested and benched it as much as I could.
Considering the big changes that came with 6.0 and the fact that the bug
did not affect polylines (it only affected what we call pulycurves), if the
backport is a hussle, then don't.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 9 Oct 2024 at 13:11, Andreas Fabri ***@***.***> wrote:
It is rather non-minimalistic with all these using changes.
—
Reply to this email directly, view it on GitHub
<#8525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOH74U5CM33ZWYDTFD3Z2T6NPAVCNFSM6AAAAABPQZBX5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRHEYDEMZXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the code that computes intersections in the polycurve traits (Arr_polycurve_traits_2).
Summary of Changes
The code of the Intersection_2 functor was developed from scratch.
The old code only supported polylines (by mistake), that is, chains of segments.
The new code supports intersections of chains of any type of sub-curves.
It turns out that the new code is ~15% more efficient.
While at it, I replaced 'typedef' statements with modern 'using' statements.
Release Management
Apparently, there is no "CHANGES.md" file yet for 6.1, so I'll add an entry that informs about this fix after it is introduced (to 'master' and 'master' is merged to this branch.)