Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGAL: Modernize CMakeLists.txt #8528

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

CGAL: Modernize CMakeLists.txt #8528

wants to merge 26 commits into from
+716 −812

Commits on Oct 8, 2024

  1. CGAL: Modernize CMakeLists.txt

    @afabri
    afabri committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5275693 View commit details
    Browse the repository at this point in the history

  2. Eigen_support -> Eigen3_support (concerns kinetic @soesau)

    @afabri
    afabri committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    63928f5 View commit details
    Browse the repository at this point in the history

  3. Eigen_support -> Eigen3_support (concerns kinetic @soesau)

    @afabri
    afabri committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    eaa2dfc View commit details
    Browse the repository at this point in the history

  4. I guess this was before inherited from one of the item classes @lrineau

    @afabri
    afabri committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    59903f1 View commit details
    Browse the repository at this point in the history

  5. more plugins depend on Eigen

    @afabri
    afabri committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ad8ece6 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Can we savely remove add_definitions(-DQT_NO_KEYWORDS) @lrineau ?

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    520a1af View commit details
    Browse the repository at this point in the history

  2. More PRIVATE in LCC and Generalized_map

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9561615 View commit details
    Browse the repository at this point in the history

  3. Use target_compile_definitions()

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    74e8e23 View commit details
    Browse the repository at this point in the history

  4. Use target_compile_definitions()

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d817dda View commit details
    Browse the repository at this point in the history

  5. Only link to Boost::program_options and not to Do the same later else… 

    …where, but let's first see a green testsuite
    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    10b3705 View commit details
    Browse the repository at this point in the history

  6. Use add_compile_definitions

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9e75ab3 View commit details
    Browse the repository at this point in the history

  7. No need to include from ../../include

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5829760 View commit details
    Browse the repository at this point in the history

  8. Only link with Boost::program_options - Supported the minimum require… 

    …d cmake
    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9bf4134 View commit details
    Browse the repository at this point in the history

  9. Use Boost::serialization and Boost::iostreams

    @afabri
    afabri committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    63d2a26 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. missing )

    @afabri
    afabri committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4bde1e6 View commit details
    Browse the repository at this point in the history

  2. Simplified CMakeLists of Point_set_processing @soesau please check

    @afabri
    afabri committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ec895d6 View commit details
    Browse the repository at this point in the history

  3. Cleanup in Shape_detection

    @afabri
    afabri committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9edf6ea View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. first batch of modifications during my review 

    [skip ci] (wait for the second batch of modifications)
    @lrineau
    lrineau committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2ca1c4e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. second batch of modifications after review

    @lrineau
    lrineau committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c0b59bd View commit details
    Browse the repository at this point in the history

  2. third batch of modifications

    @lrineau
    lrineau committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d759e72 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'cgal/master' into pr/afabri/8528

    @lrineau
    lrineau committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    96cd3e6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'cgal/master' into pr/afabri/8528

    @lrineau
    lrineau committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d7dc57f View commit details
    Browse the repository at this point in the history

  5. fix the documentation

    @lrineau
    lrineau committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a0d79b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. leftovers I had not pointed out 

    I have reviewed all modifications. It should be the last batch.
    @lrineau
    lrineau committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    439df74 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. fixes

    @lrineau
    lrineau committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    868e351 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'cgal/master' into pr/afabri/8528

    @lrineau
    lrineau committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fb2a9ea View commit details
    Browse the repository at this point in the history