Spatial_searching: Do not quiet warning in CMakeLists.txt #8529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not get a warning with |
|
Note that those lines were from a77205a, about ten years ago. |
|
Successfully tested in CGAL-6.0.1-Ic-351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
It is not a good idea to quiet a warning in the
CMakeLists.txtfile.Todo: Fix it in the code, or disable warning in the header file itself.
There is another warning disabled in the test of
Distance_3. The question is if we have a test case where we force it into the problem, or if the same warning can show up for any user code. The warning does not show up outside this testsuite which might be an indication.Release Management