Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shape detection] Removed use of internal namespace from example #8535

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[Shape detection] Removed use of internal namespace from example #8535

merged 2 commits into from
Oct 14, 2024

Conversation

soesau
Copy link
Member

@soesau soesau commented Oct 10, 2024

Summary of Changes

Documented that RegionType::Item and NeighborQuery::Item need to be hashable.
Removed internal namespace from example.

Release Management

@sloriot
Copy link
Member

sloriot commented Oct 14, 2024

Successfully tested in CGAL-6.0.1-Ic-345

@sloriot sloriot changed the base branch from 5.6.x-branch to master October 14, 2024 12:17
@sloriot sloriot merged commit aedf601 into CGAL:master Oct 14, 2024
8 checks passed
@sloriot sloriot deleted the Shape_detection-No_internal_in_examples-GF branch October 14, 2024 12:17
@lrineau lrineau added this to the 6.0.1 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri approved these changes

Assignees
No one assigned
Labels
Pkg::Shape_detection Tested
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@soesau @sloriot @afabri @lrineau