Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lab] Fix transparency #8540

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

soesau
Copy link
Member

@soesau soesau commented Oct 14, 2024

Summary of Changes

The viewer does not return the dimensions of the framebuffer, thus the viewport information is used to create the framebuffers for depth peeling. Also the correct width and height are communicated to the shader.

Release Management

  • Affected package(s): Lab

@afabri
Copy link
Member

afabri commented Oct 14, 2024

I am wondering what the semantics of viewer.width() is?

@sloriot
Copy link
Member

sloriot commented Oct 18, 2024

Successfully tested in CGAL-6.0.1-Ic-351

@sloriot sloriot merged commit aed66d9 into CGAL:5.6.x-branch Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants