Continuing of sundials branch PR #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n label for Newton solver based on numerical recipes.
…for the numerical recipes Newton solver in data_types module.
Using the "homegrown" label instead of "numrec" for the Newton solver based on Press et al.
…evelop * 'develop' of https://github.com/ashleymedin/summa: capital letter
# Conflicts: # build/CMakeLists.txt
MaxErrTest failures set to 10 was too low. Setting this value to 50 allows GRUs a better chance to succeed on the first attempt
…nan for rawCanopyWetFraction. This happens because the value of rawWetFractionDeriv is blowing up, even with smoothing on -- the smoothing function does not do enough when canopyWettingExp gets smaller. If tie smoothing to canopyWettingExp would probably speed up the code.
The findCmake files were not being read by SUMMA, and the ngen ones were being used. However, SUMMA could not use these paths. By setting the CMAKE_MODULE_PATH and PREFIX_PATH variables to include the summa specific finds first the problem goes away.
summabmi.pc.in is needed to compile nextGen
…ut off derivative
…for now because I think it works better
…nstable and it was clear that the current calculation of the mean fluxes was incorrect in IDA (this only affects IDA flux output, uses instantaneous flux in solver). Does not affect BE solver.
Updated Compilation for Summa-Actors
…evelop * 'develop' of https://github.com/ashleymedin/summa: Remove Summa-Actors specific files from cmakelist.txt for summa non-actors Current cmake_lists file represents what has been converted to CAF version 1 Starting conversion to V1 of CAF Adjust default value for errTestFailures: remove unnecessary module import
…nk to Summa-Actors
Remove left over actors commands from CMake. Left instructions and li…
…serv = closedForm flag to indicate if we update Cp at each step logical(lgt),parameter :: needCm_closedForm=.true. ! nrgConserv = closedForm flag to indicate if the energy equation contains Cm = dH_T/dTheta_m
|
Merging as per @ashleymedin 's request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing, current changes are from Sean to make
numrecdecisionhomegrown(backwards compatible toitertive.