SPIR-V portability fix for single element vectors #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add also to 1.1. |
linehill
force-pushed
the
avoid-1elt-vecs
branch
from
626f5a4 to
c0821a2
Compare
pvelesko
force-pushed
the
avoid-1elt-vecs
branch
from
c0821a2 to
b1a401e
Compare
|
rebased on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust a HIP header for avoiding single element vectors to appear in LLVM IR. Single element vectors are not supported in SPIR-V without an extension (e.g. SPV_INTEL_vector_compute) which are enabled with hard coded --spirv-ext=+all option in clang.
I'll make clang patch to disable all SPIR-V extension which will cause an assertion to be triggered in
llvm-spirvif there are single element vectors in the input device code.Related to issue #713.
(We had this patch previously but it got lost in #521)