Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent InvalidBitWidth Errors #963

Merged
merged 17 commits into from
Feb 6, 2025
+503 −2
Merged

Prevent InvalidBitWidth Errors #963

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9c43894
Add a test for InvalidBitWidth
pvelesko Jan 20, 2025
183ef96
Fix invalid bitwidth LLVM Pass.
pvelesko Jan 20, 2025
a78490e
Reimplement promotion via recursion
pvelesko Jan 22, 2025
3e2ce41
Accept 128 generation as accepted for now
pvelesko Jan 23, 2025
2348297
Always promote phi node
pvelesko Jan 23, 2025
061c167
Assert on unhandled instructions
pvelesko Jan 23, 2025
40b5aab
rename PromoteChainPrint PromoteChain
pvelesko Jan 23, 2025
6603684
debug prints in getPromotedValue
pvelesko Jan 23, 2025
9fe898d
Abort on calls to funcs with non-std type args
pvelesko Jan 30, 2025
e9472f1
avoid string copy
pvelesko Feb 4, 2025
b79e83c
cleanup
pvelesko Feb 4, 2025
c8b4950
Add a correctness check for bitwidth
pvelesko Feb 4, 2025
3e55b9a
static void promote chain
pvelesko Feb 4, 2025
491a922
errs -> debug
pvelesko Feb 4, 2025
bc6d0af
Add algorithm explanation
pvelesko Feb 4, 2025
3610bf0
fmt + fix return
pvelesko Feb 4, 2025
cd8b100
style fmt
pvelesko Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm_passes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ add_library(LLVMHipPasses MODULE HipPasses.cpp
HipPrintf.cpp HipGlobalVariables.cpp HipTextureLowering.cpp HipAbort.cpp
HipEmitLoweredNames.cpp HipWarps.cpp HipKernelArgSpiller.cpp
HipLowerZeroLengthArrays.cpp HipSanityChecks.cpp HipLowerSwitch.cpp
HipLowerMemset.cpp HipIGBADetector.cpp ${EXTRA_OBJS})
HipLowerMemset.cpp HipIGBADetector.cpp HipPromoteInts.cpp ${EXTRA_OBJS})

# If trying to recompile with LLVM unloaded, the inlcude path is not found
target_compile_options(LLVMHipDynMem PRIVATE -I/${LLVM_INCLUDE_DIRS})
Expand Down
4 changes: 4 additions & 0 deletions llvm_passes/HipPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "HipLowerSwitch.h"
#include "HipLowerMemset.h"
#include "HipIGBADetector.h"
#include "HipPromoteInts.h"

#include "llvm/IR/Module.h"
#include "llvm/Passes/PassBuilder.h"
Expand Down Expand Up @@ -99,6 +100,9 @@ class HipFixOpenCLMDPass : public PassInfoMixin<HipFixOpenCLMDPass> {
static void addFullLinkTimePasses(ModulePassManager &MPM) {
MPM.addPass(HipSanityChecksPass());

// Fix InvalidBitWidth errors due to non-standard integer types
MPM.addPass(HipPromoteIntsPass());

/// For extracting name expression to lowered name expressions (hiprtc).
MPM.addPass(HipEmitLoweredNamesPass());

Expand Down
Loading