Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Machine Ports, Add CPPs NO_CDF2, NO_CDF5 #956

Merged
merged 3 commits into from
May 18, 2024
Merged

Update Machine Ports, Add CPPs NO_CDF2, NO_CDF5 #956

merged 3 commits into from
May 18, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 17, 2024 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Machine ports, Add CPPs NO_CDF2, NO_CDF5
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    testing on several machines concurrently as part of pre-release testing, results are bit-for-bit.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

These changes are associated with the multi-machine pre-release testing for CICE.

Update Hera port, new compiler version

Add NO_CDF2, NO_CDF5, and NO_HDF5 CPP options to model to support older/other versions of netcdf. Several machines with only netcdf 4.4 do not support cdf5 format. Sometimes netcdf is not built with hdf5. We need a CPP to avoid that part of the code to allow the model to build on those machines.

Set NO_CDF5 for gaffney, koehr, mustang machines

Set NO_HDF5 for compy

Update documentation

@apcraig
Update hera port
af2bdec 
Add NO_CDF2 and NO_CDF5 CPP options to model to support older versions of netcdf

Set NO_CDF5 for gaffney, koehr, mustang machines

Update documentation
@apcraig apcraig requested review from eclare108213 and dabail10 May 17, 2024 04:54
@apcraig apcraig self-assigned this May 17, 2024
apcraig added 2 commits May 17, 2024 10:33
eclare108213
eclare108213 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if developers of other software packages (including but not limited to netcdf) would try a bit harder to ensure backward and cross-compatibility... Thanks for dealing with it.

@apcraig apcraig merged commit 4587504 into CICE-Consortium:main May 18, 2024
2 checks passed
@NickSzapiro-NOAA NickSzapiro-NOAA mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 Awaiting requested review from dabail10

Assignees

@apcraig apcraig

Labels
Porting Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213