Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Spatial Conditions #12

Merged
merged 29 commits into from
Feb 19, 2021
Merged

Implement Spatial Conditions #12

merged 29 commits into from
Feb 19, 2021

Conversation

alelom
Copy link
Contributor

@alelom alelom commented Feb 8, 2021 •
edited by al-fisher
Loading

NOTE: Depends on

BHoM/BHoM_Engine#2308

alelom added 24 commits February 8, 2021 17:35
@alelom
first implementation
abc1b04
@alelom
changes to structure of conditions
25374e8
@alelom
Added methods to convert spatialCondition to boundingBoxCondition. Re…
a596052 
…factor
@alelom
refactoring. added methods for applying condition.
cc43888
@alelom
Added ApplyBoundingBoxCondition. Refactor.
9be96cf
@alelom
Update CIH_Engine.csproj
f95f7f7
@alelom
Another iteration
e7c7e02
@alelom
Refactored: added ZoneSpecs/SpatialSpecs.
c639c22
@alelom
Added filter of objects from SpatialSpecification.
d716b6d
@alelom
Corrections to filter
33f5570
@alelom
Refactored for 1 zoneSpec per 1 SpatialSpec. Corrections.
621883b
@alelom
Update ApplyLogicalCondition.cs
1fd2bb6
@alelom
Correction to IElementBoundingBox.
6861b87
@alelom
Added description to BoundingBoxCondition property
50e7415
@alelom
Added toString() to Zone/Spatial specifications
c474940
@alelom
Correction to logicalCondition
1560720
@alelom
Corrections.
ac7505b
@alelom
Corrections to the ToString methods
8a297e9
@alelom
Added workaround to missing BHoM/BHoM_Engine#2316
b5c9cb8
@alelom
added description
b16da72
@alelom
Added copyright headers
5f4c43f
@alelom
Create ZoneReferenceLine.cs
66af561
@alelom
Revert "Added copyright headers"
7f7ba79 
This reverts commit 5f4c43f.
@alelom
Update CIH_oM.csproj
5855a44
@alelom alelom requested a review from al-fisher February 19, 2021 11:02
@alelom alelom self-assigned this Feb 19, 2021
@alelom alelom added the type:feature New capability or enhancement label Feb 19, 2021
@alelom alelom marked this pull request as ready for review February 19, 2021 11:02
@alelom
Copy link
Contributor Author

alelom commented Feb 19, 2021 •
edited
Loading

Added #13 which is the largest missing part from this PR currently, because it kind of does not allow a particular workflow.

Also added #14, #15 for the Cuboid containment.

al-fisher
al-fisher approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing based on our recent Beam specs and product configurator experiments.

Working well. Great stuff @alelom
A number of possible improvements as already raised by you @alelom and the comments in code regarding possible consolidations of terminology around Zones/Spatial Specs and Applied Specs. All to be picked up in continuing discussions and future issues
🚀

@al-fisher al-fisher merged commit 2d66057 into master Feb 19, 2021
@al-fisher al-fisher deleted the CIH_Engine-SpatialCondition branch February 19, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-fisher al-fisher al-fisher approved these changes

Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alelom @al-fisher