forked from clarin-eric/oai-harvest-manager
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free up action #23
Open
vicding-mi
wants to merge
20
commits into
develop
Choose a base branch
from
free_action
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Free up action #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the develop branch where the 1.2 release was prepared
docemented changes
Get filter.xsl from the right spot.
v1.2.1: security fixes
Almost accidentally removed the whole branch, merge the freed up action into dev first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the actions from the main package. After adoption of the package, extra actions can be invoked by adding particular actions to the config file
The line
<action type="nl.knaw.huc.di.sd.HelloWorldAction" file="extra-actions.jar" />
, indicates a new action and informs where to get the jar contains the definition of it.<action type="nl.mpi.oai.harvester.action.SplitAction" />
indicates that when there is no jar file given, the harvester will fall back to class path for action look up. The internalsplit
action is used but called with its full qualified name.The action JAR should implement, for example