-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update pipelines #230
Draft
ktagowski
wants to merge
6
commits into
main
Choose a base branch
from
fix/update-pipelines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix/update pipelines #230
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
362feb0
feat(transformation): Add ClassEncodeColumnTransformation
ktagowski 6d18471
fix(flair_pipelines): Fix flair pipelines
ktagowski c79029b
fix(configspace): Fix flair configspace
ktagowski 4e957f2
fix(hps_metadata): Fix flair hps_metadata
ktagowski 9e69742
refactor: Update embeddings/pipeline/flair_preprocessing_pipeline.py
ktagowski d902d26
refactor: Refactor code after review
ktagowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
embeddings/transformation/hf_transformation/class_encode_column_transformation.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import datasets | ||
|
||
from embeddings.transformation.transformation import Transformation | ||
|
||
|
||
class ClassEncodeColumnTransformation(Transformation[datasets.DatasetDict, datasets.DatasetDict]): | ||
def __init__( | ||
self, | ||
column: str, | ||
): | ||
self.column = column | ||
|
||
def transform(self, data: datasets.DatasetDict) -> datasets.DatasetDict: | ||
return data.class_encode_column(column=self.column) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider early exit, without extra nested if?
if self.encode_labels and isinstance(data_loader, (ConllFlairCorpusDataLoader, PickleFlairCorpusDataLoader)):
raise ValueError(
"ClassEncodeColumnTransformation transformation is unavailable for Flair DataLoaders. "
"Set parameter
encode_labels
value to True")
transformation= transformation.then(
ClassEncodeColumnTransformation(column=self.target_column_name)
) if self.encode_labels else transformation