Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce centroid resolution from 30/60/60 to 0.1 in test #149

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

chahank
Copy link
Member

@chahank chahank commented Nov 22, 2024

Changes proposed in this PR:

  • Reduce the centroids resolution from 30/60/60 to 0.1 in the unit test for GeoClaw form tracks.
  • This reduces the test time from 60s to 1s.

This PR partially fixes #148

@NicolasColombi
Copy link
Collaborator

nice fix 👍🏼 it takes 1.3s on my laptop as well

@chahank
Copy link
Member Author

chahank commented Nov 22, 2024

@NicolasColombi can you merge if you agree with the change?

@NicolasColombi
Copy link
Collaborator

Yes @chahank, can you grant me the write access for petals ? I only have it for climada_python

@NicolasColombi NicolasColombi merged commit 4072e19 into develop Nov 22, 2024
11 checks passed
@NicolasColombi NicolasColombi deleted the fix/long_geoclaw_unittest branch November 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants